netdev - Re: [PATCH v5 01/17] dt-bindings: net: wireless: cc33xx: Add ti,cc33xx.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1e84b675-a0a0-414c-9f42-45a958dc0724@ti.com>
Date: Tue, 19 Nov 2024 14:10:30 +0200
From: "Nemanov, Michael" <michael.nemanov@...com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Kalle Valo <kvalo@...nel.org>, "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo
 Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, <linux-wireless@...r.kernel.org>,
        <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Sabeeh Khan
	<sabeeh-khan@...com>
Subject: Re: [PATCH v5 01/17] dt-bindings: net: wireless: cc33xx: Add
 ti,cc33xx.yaml

On 11/19/2024 11:15 AM, Krzysztof Kozlowski wrote:
> On 12/11/2024 07:45, Nemanov, Michael wrote:
>> On 11/8/2024 2:02 PM, Krzysztof Kozlowski wrote:
>>> On Thu, Nov 07, 2024 at 02:51:53PM +0200, Michael Nemanov wrote:
>>>> Add device-tree bindings for the CC33xx family.
>>>>
>>>> Signed-off-by: Michael Nemanov <michael.nemanov@...com>
>>>> ---
>>>>    .../bindings/net/wireless/ti,cc33xx.yaml      | 59 +++++++++++++++++++
>>>>    1 file changed, 59 insertions(+)
>>>>    create mode 100644 Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml
>>>>
>>>
>>> <form letter>
>>> This is a friendly reminder during the review process.
>>>
>>> It seems my or other reviewer's previous comments were not fully
>>> addressed. Maybe the feedback got lost between the quotes, maybe you
>>> just forgot to apply it. Please go back to the previous discussion and
>>> either implement all requested changes or keep discussing them.
>>>
>>> Thank you.
>>> </form letter>
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> Are you referring to
>>
>>> diff --git a/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml b/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml
>>
>> ...
>>
>>> +
>>> +properties:
>>> +  $nodename:
>>> +    pattern: "^wifi@2"
>>
>> ?
>>
>> If so, I replied here
>> https://lore.kernel.org/linux-wireless/8024aa1c-5bd1-40d8-b0c3-14b5fcd992e2@ti.com/#t
>> But if you don't think it's worthwhile I'll remove it.
> 
> I asked you to remove it. It's not correct, not needed, not beneficial
> at all. It is actually harmful because limits re-use. dtc already checks
> this.
> 
> Best regards,
> Krzysztof
> 

OK, I'll remove it in the next iteration.

Regards,
Michael.