Message-Id: <99755FD2-270C-4122-8A22-6C73A81028F6@gmail.com>
Date: Tue, 19 Nov 2024 09:43:32 +0800
From: zhang warden <zhangwarden@...il.com>
To: Easwar Hariharan <eahariha@...ux.microsoft.com>
Cc: Petr Mladek <pmladek@...e.com>,
 Christophe Leroy <christophe.leroy@...roup.eu>,
 Pablo Neira Ayuso <pablo@...filter.org>,
 Jozsef Kadlecsik <kadlec@...filter.org>,
 "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>,
 Julia Lawall <Julia.Lawall@...ia.fr>,
 Nicolas Palix <nicolas.palix@...g.fr>,
 Daniel Mack <daniel@...que.org>,
 Haojian Zhuang <haojian.zhuang@...il.com>,
 Robert Jarzmik <robert.jarzmik@...e.fr>,
 Russell King <linux@...linux.org.uk>,
 Heiko Carstens <hca@...ux.ibm.com>,
 Vasily Gorbik <gor@...ux.ibm.com>,
 Alexander Gordeev <agordeev@...ux.ibm.com>,
 Christian Borntraeger <borntraeger@...ux.ibm.com>,
 Sven Schnelle <svens@...ux.ibm.com>,
 Ofir Bitton <obitton@...ana.ai>,
 Oded Gabbay <ogabbay@...nel.org>,
 Lucas De Marchi <lucas.demarchi@...el.com>,
 Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
 Rodrigo Vivi <rodrigo.vivi@...el.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>,
 Jeroen de Borst <jeroendb@...gle.com>,
 Praveen Kaligineedi <pkaligineedi@...gle.com>,
 Shailend Chand <shailend@...gle.com>,
 Andrew Lunn <andrew+netdev@...n.ch>,
 James Smart <james.smart@...adcom.com>,
 Dick Kennedy <dick.kennedy@...adcom.com>,
 "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Roger Pau Monné <roger.pau@...rix.com>,
 Jens Axboe <axboe@...nel.dk>,
 Kalle Valo <kvalo@...nel.org>,
 Jeff Johnson <jjohnson@...nel.org>,
 Catalin Marinas <catalin.marinas@....com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Jack Wang <jinpu.wang@...ud.ionos.com>,
 Marcel Holtmann <marcel@...tmann.org>,
 Johan Hedberg <johan.hedberg@...il.com>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Ray Jui <rjui@...adcom.com>,
 Scott Branden <sbranden@...adcom.com>,
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
 Xiubo Li <xiubli@...hat.com>,
 Ilya Dryomov <idryomov@...il.com>,
 Josh Poimboeuf <jpoimboe@...nel.org>,
 Jiri Kosina <jikos@...nel.org>,
 Miroslav Benes <mbenes@...e.cz>,
 Joe Lawrence <joe.lawrence@...hat.com>,
 Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>,
 Lucas Stach <l.stach@...gutronix.de>,
 Russell King <linux+etnaviv@...linux.org.uk>,
 Christian Gmeiner <christian.gmeiner@...il.com>,
 Louis Peens <louis.peens@...igine.com>,
 Michael Ellerman <mpe@...erman.id.au>,
 Nicholas Piggin <npiggin@...il.com>,
 Naveen N Rao <naveen@...nel.org>,
 Madhavan Srinivasan <maddy@...ux.ibm.com>,
 netfilter-devel@...r.kernel.org,
 coreteam@...filter.org,
 netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 cocci@...ia.fr,
 linux-arm-kernel@...ts.infradead.org,
 linux-s390@...r.kernel.org,
 dri-devel@...ts.freedesktop.org,
 intel-xe@...ts.freedesktop.org,
 linux-scsi@...r.kernel.org,
 xen-devel@...ts.xenproject.org,
 linux-block@...r.kernel.org,
 linux-wireless@...r.kernel.org,
 ath11k@...ts.infradead.org,
 linux-mm@...ck.org,
 linux-bluetooth@...r.kernel.org,
 linux-staging@...ts.linux.dev,
 linux-rpi-kernel@...ts.infradead.org,
 ceph-devel@...r.kernel.org,
 live-patching@...r.kernel.org,
 linux-sound@...r.kernel.org,
 etnaviv@...ts.freedesktop.org,
 oss-drivers@...igine.com,
 linuxppc-dev@...ts.ozlabs.org,
 Anna-Maria Behnsen <anna-maria@...utronix.de>
Subject: Re: [PATCH v2 19/21] livepatch: Convert timeouts to secs_to_jiffies()



> On Nov 19, 2024, at 02:18, Easwar Hariharan <eahariha@...ux.microsoft.com> wrote:
> 
> On 11/18/2024 3:06 AM, Petr Mladek wrote:
>> On Sat 2024-11-16 11:10:52, Christophe Leroy wrote:
>>> 
>>> 
>>> Le 15/11/2024 à 22:26, Easwar Hariharan a écrit :
>>>> [Vous ne recevez pas souvent de courriers de eahariha@...ux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>>>> 
>>>> Changes made with the following Coccinelle rules:
>>>> 
>>>> @@ constant C; @@
>>>> 
>>>> - msecs_to_jiffies(C * 1000)
>>>> + secs_to_jiffies(C)
>>>> 
>>>> @@ constant C; @@
>>>> 
>>>> - msecs_to_jiffies(C * MSEC_PER_SEC)
>>>> + secs_to_jiffies(C)
>>>> 
>>>> Signed-off-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
>>>> ---
>>>>  samples/livepatch/livepatch-callbacks-busymod.c |  2 +-
>>>>  samples/livepatch/livepatch-shadow-fix1.c       |  2 +-
>>>>  samples/livepatch/livepatch-shadow-mod.c        | 10 +++++-----
>>>>  3 files changed, 7 insertions(+), 7 deletions(-)
>>>> 
>>>> diff --git a/samples/livepatch/livepatch-callbacks-busymod.c b/samples/livepatch/livepatch-callbacks-busymod.c
>>>> index 378e2d40271a9717d09eff51d3d3612c679736fc..d0fd801a7c21b7d7939c29d83f9d993badcc9aba 100644
>>>> --- a/samples/livepatch/livepatch-callbacks-busymod.c
>>>> +++ b/samples/livepatch/livepatch-callbacks-busymod.c
>>>> @@ -45,7 +45,7 @@ static int livepatch_callbacks_mod_init(void)
>>>>  {
>>>>         pr_info("%s\n", __func__);
>>>>         schedule_delayed_work(&work,
>>>> -               msecs_to_jiffies(1000 * 0));
>>>> +               secs_to_jiffies(0));
>>> 
>>> Using secs_to_jiffies() is pointless, 0 is universal, should become
>>> schedule_delayed_work(&work, 0);
>> 
>> Yes, schedule_delayed_work(&work, 0) looks like the right solution.
>> 
>> Or even better, it seems that the delayed work might get replaced by
>> a normal workqueue work.
>> 
>> Anyway, I am working on a patchset which would remove this sample
>> module. There is no need to put much effort into the clean up
>> of this particular module. Do whatever is easiest for you.
>> 
>> Best Regards,
>> Petr
> 
> If we're removing the module, I'll drop it from the series. Just to
> clarify, do you mean to remove all of samples/livepatch/* or some
> particular file(s)?
> 
> Thanks,
> Easwar
> 

Hi Easwar!

I think Petr is going to remove just this module away. Anyway, I don't think
removing all of them is a good idea.

Thanks.
Wardenjohn. 

Powered by blists - more mailing lists