netdev - 回覆: [net-next 3/3] net: mdio: aspeed: Add dummy read for fire control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB51342D31DBD3C0BE9E81977B9D202@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Tue, 19 Nov 2024 05:51:04 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Andrew Lunn <andrew@...n.ch>, Andrew Jeffery <andrew@...econstruct.com.au>
CC: "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"joel@....id.au" <joel@....id.au>, "hkallweit1@...il.com"
	<hkallweit1@...il.com>, "linux@...linux.org.uk" <linux@...linux.org.uk>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject:
 回覆: [net-next 3/3] net: mdio: aspeed: Add dummy read for fire control

Hi Andrew Lunn,

Thank you for your reply.

> > >         iowrite32(ctrl, ctx->base + ASPEED_MDIO_CTRL);
> > > +       /* Add dummy read to ensure triggering mdio controller */
> > > +       (void)ioread32(ctx->base + ASPEED_MDIO_CTRL);
> >
> > Why do this when the same register is immediately read by
> > readl_poll_timeout() below?
> >
> > If there is a reason, I'd like some more explanation in the comment
> > you've added, discussing the details of the problem it's solving when
> > taking into account the readl_poll_timeout() call.
> 
> Also, is this a fix? Should it have a Fixes: tag? If so, it should not be part of this
> series, assuming the older devices have the same issue.

Agree.
It may be a fix. The patch is also applied in older device.
I will separate from this series and send it to net tree.

Thanks,
Jacky