netdev - Re: [PATCH net-next v3 8/8] dt-bindings: net: sparx5: document RGMII delays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241120105336.3wheaindiv5q3uvj@DEN-DL-M70577>
Date: Wed, 20 Nov 2024 10:53:36 +0000
From: Daniel Machon <daniel.machon@...rochip.com>
To: Rob Herring <robh@...nel.org>
CC: <UNGLinuxDriver@...rochip.com>, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Lars
 Povlsen" <lars.povlsen@...rochip.com>, Steen Hegelund
	<Steen.Hegelund@...rochip.com>, Horatiu Vultur
	<horatiu.vultur@...rochip.com>, Russell King <linux@...linux.org.uk>,
	<jacob.e.keller@...el.com>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
	<devicetree@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH net-next v3 8/8] dt-bindings: net: sparx5: document RGMII
 delays

Hi Rob,

> > The lan969x switch device supports two RGMII port interfaces that can be
> > configured for MAC level rx and tx delays.
> >
> > Document two new properties {rx,tx}-internal-delay-ps. Make them
> > required properties, if the phy-mode is one of: rgmii, rgmii_id,
> > rgmii-rxid or rgmii-txid. Also specify accepted values.
> 
> Doesn't look like they are required to me.

Commit description needs updating. Thanks for catching this!

> 
> >
> > Signed-off-by: Daniel Machon <daniel.machon@...rochip.com>
> > ---
> >  .../bindings/net/microchip,sparx5-switch.yaml          | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml b/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> > index dedfad526666..2e9ef0f7bb4b 100644
> > --- a/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> > +++ b/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> > @@ -129,6 +129,24 @@ properties:
> >              minimum: 0
> >              maximum: 383
> >
> > +          rx-internal-delay-ps:
> > +            description: |
> 
> Don't need '|' if there is not formatting to preserve.

Ack.

> 
> > +              RGMII Receive Clock Delay defined in pico seconds, used to select
> > +              the DLL phase shift between 1000 ps (45 degree shift at 1Gbps) and
> > +              3300 ps (147 degree shift at 1Gbps). A value of 0 ps will disable
> > +              any delay. The Default is no delay.
> > +            enum: [0, 1000, 1700, 2000, 2500, 3000, 3300]
> > +            default: 0
> > +
> > +          tx-internal-delay-ps:
> > +            description: |
> > +              RGMII Transmit Clock Delay defined in pico seconds, used to select
> > +              the DLL phase shift between 1000 ps (45 degree shift at 1Gbps) and
> > +              3300 ps (147 degree shift at 1Gbps). A value of 0 ps will disable
> > +              any delay. The Default is no delay.
> > +            enum: [0, 1000, 1700, 2000, 2500, 3000, 3300]
> > +            default: 0
> > +
> >          required:
> >            - reg
> >            - phys
> >
> > --
> > 2.34.1
> >

/Daniel