netdev - Re: [PATCH net-next v3 2/7] net: faraday: Add ARM64 in FTGMAC100 for AST2700

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <846e2d7e-33bf-4aa5-8e33-e2c4fffb4f7a@kernel.org>
Date: Mon, 25 Nov 2024 17:12:47 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jacky Chou <jacky_chou@...eedtech.com>, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 p.zabel@...gutronix.de, ratbert@...aday-tech.com, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 2/7] net: faraday: Add ARM64 in FTGMAC100 for
 AST2700

On 20/11/2024 08:50, Jacky Chou wrote:
> AST2700 is a ARM 64-bit SoC and ftgmac100 adds support 64-bit
> DMA capability in AST2700.
> 
> Signed-off-by: Jacky Chou <jacky_chou@...eedtech.com>
> ---
>  drivers/net/ethernet/faraday/Kconfig | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/faraday/Kconfig b/drivers/net/ethernet/faraday/Kconfig
> index c699bd6bcbb9..d5a088d88c3d 100644
> --- a/drivers/net/ethernet/faraday/Kconfig
> +++ b/drivers/net/ethernet/faraday/Kconfig
> @@ -6,7 +6,7 @@
>  config NET_VENDOR_FARADAY
>  	bool "Faraday devices"
>  	default y
> -	depends on ARM || COMPILE_TEST
> +	depends on ARM || ARM64 || COMPILE_TEST
>  	help
>  	  If you have a network (Ethernet) card belonging to this class, say Y.
>  
> @@ -28,8 +28,7 @@ config FTMAC100
>  
>  config FTGMAC100
>  	tristate "Faraday FTGMAC100 Gigabit Ethernet support"
> -	depends on ARM || COMPILE_TEST
> -	depends on !64BIT || BROKEN
Explain in commit msg how did you unbreak it. Better, combine it with
commit which actually fixes broken 64bit.

Best regards,
Krzysztof