netdev - Re: [PATCH net-next v3 1/7] dt-bindings: net: ftgmac100: support for AST2700

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de34a628-a74c-4558-817e-345a3de46e2e@kernel.org>
Date: Mon, 25 Nov 2024 17:13:37 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Philipp Zabel <p.zabel@...gutronix.de>,
 Jacky Chou <jacky_chou@...eedtech.com>, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 ratbert@...aday-tech.com, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH net-next v3 1/7] dt-bindings: net: ftgmac100: support for
 AST2700

On 25/11/2024 11:24, Philipp Zabel wrote:
> On Mi, 2024-11-20 at 15:50 +0800, Jacky Chou wrote:
>> The AST2700 is the 7th generation SoC from Aspeed.
>> Add compatible support for AST2700 in yaml.
>>
>> Signed-off-by: Jacky Chou <jacky_chou@...eedtech.com>
>> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
>> ---
>>  Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
>> index 9bcbacb6640d..fffe5c51daa9 100644
>> --- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
>> +++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
>> @@ -21,6 +21,7 @@ properties:
>>                - aspeed,ast2400-mac
>>                - aspeed,ast2500-mac
>>                - aspeed,ast2600-mac
>> +              - aspeed,ast2700-mac
>>            - const: faraday,ftgmac100
>>  
>>    reg:
>> @@ -33,7 +34,7 @@ properties:
>>      minItems: 1
>>      items:
>>        - description: MAC IP clock
>> -      - description: RMII RCLK gate for AST2500/2600
>> +      - description: RMII RCLK gate for AST2500/2600/2700
>>  
>>    clock-names:
>>      minItems: 1
> 
> Given patch 3, I would expect a resets property to be defined and
> possibly added to the list of required properties for aspeed,ast2700-
> mac.


Yeah, DTS was not tested at all.

Jacky, where is the DTS, so we can validate it? Please provide link in
cover letter.

Best regards,
Krzysztof