netdev - Re: [PATCH net v1 3/3] bnxt_en: handle tpa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7741c66f-ee1f-4783-baad-9335df6e3c20@davidwei.uk>
Date: Tue, 26 Nov 2024 21:38:05 -0800
From: David Wei <dw@...idwei.uk>
To: Somnath Kotur <somnath.kotur@...adcom.com>
Cc: netdev@...r.kernel.org, Michael Chan <michael.chan@...adcom.com>,
 Andy Gospodarek <andrew.gospodarek@...adcom.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net v1 3/3] bnxt_en: handle tpa_info in queue API
 implementation

On 2024-11-25 22:33, Somnath Kotur wrote:
> On Mon, Nov 25, 2024 at 9:54 AM David Wei <dw@...idwei.uk> wrote:
>>
>> Commit 7ed816be35ab ("eth: bnxt: use page pool for head frags") added a
>> page pool for header frags, which may be distinct from the existing pool
>> for the aggregation ring. Add support for this head_pool in the queue
>> API.
>>
>> Signed-off-by: David Wei <dw@...idwei.uk>
>> ---
>>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 24 +++++++++++++++++++----
>>  1 file changed, 20 insertions(+), 4 deletions(-)
>>
...
>> @@ -15545,7 +15562,6 @@ static int bnxt_queue_stop(struct net_device *dev, void *qmem, int idx)
>>         bnxt_hwrm_rx_ring_free(bp, rxr, false);
>>         bnxt_hwrm_rx_agg_ring_free(bp, rxr, false);
>>         rxr->rx_next_cons = 0;
>> -       page_pool_disable_direct_recycling(rxr->page_pool);
> Intended? Not sure I understood this one, while I got the rest of the patch

Oops, not intended, thanks for catching this stray line. Will remove.