netdev - Re: Re: [RFC] ipv4: remove useless arg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <512baaf8.86d5.1936c3b8b2e.Coremail.tianyu2@kernelsoft.com>
Date: Wed, 27 Nov 2024 14:07:41 +0800 (GMT+08:00)
From: 田宇2 <tianyu2@...nelsoft.com>
To: "Eric Dumazet" <eric.dumazet@...il.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: Re: [RFC] ipv4: remove useless arg


> On 11/26/24 2:19 PM, tianyu2 wrote:
> > When I wanted to kprobe the ip_rcv_finish_core, I found that using x1 to
> > pass "struct sk_buff *skb"."struct sock *sk" was not used in the
> > function, causing the compiler to optimize away. This resulted in a
> > hard to use kprobe. Why not delete him?
> >
> > Signed-off-by: tianyu2 <tianyu2@...nelsoft.com>
> > ---
> 
> This is great seeing compilers being smart.
> 
> SGTM, please send this next week when net-next is open again.
> 
> Also do the same for ip_list_rcv_finish()
> 
Okay, thanks for the reply.