netdev - Re: [PATCH net v2 3/3] bnxt_en: handle tpa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241130141531.6fd449e1@kernel.org>
Date: Sat, 30 Nov 2024 14:15:31 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: David Wei <dw@...idwei.uk>
Cc: netdev@...r.kernel.org, Michael Chan <michael.chan@...adcom.com>, Andy
 Gospodarek <andrew.gospodarek@...adcom.com>, Somnath Kotur
 <somnath.kotur@...adcom.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net v2 3/3] bnxt_en: handle tpa_info in queue API
 implementation

On Wed, 27 Nov 2024 14:38:55 -0800 David Wei wrote:
> +	if (bp->flags & BNXT_FLAG_TPA) {
> +		rc = bnxt_alloc_one_tpa_info(bp, clone);
> +		if (rc)
> +			goto err_free_tpa_info;
> +	}
> +
>  	bnxt_init_one_rx_ring_rxbd(bp, clone);
>  	bnxt_init_one_rx_agg_ring_rxbd(bp, clone);
>  
>  	bnxt_alloc_one_rx_ring_skb(bp, clone, idx);
>  	if (bp->flags & BNXT_FLAG_AGG_RINGS)
>  		bnxt_alloc_one_rx_ring_page(bp, clone, idx);
> +	if (bp->flags & BNXT_FLAG_TPA)
> +		bnxt_alloc_one_tpa_info_data(bp, clone);

Could you explain the TPA related changes in the commit message?
Do we need to realloc the frags now since they don't come from 
system memory?