netdev - Re: [PATCH net v2 3/3] bnxt_en: handle tpa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <836ecdec-fe6e-41c7-a388-cd63ac884c05@davidwei.uk>
Date: Sat, 30 Nov 2024 14:52:12 -0800
From: David Wei <dw@...idwei.uk>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Somnath Kotur <somnath.kotur@...adcom.com>, netdev@...r.kernel.org,
 Michael Chan <michael.chan@...adcom.com>,
 Andy Gospodarek <andrew.gospodarek@...adcom.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net v2 3/3] bnxt_en: handle tpa_info in queue API
 implementation

On 2024-11-30 14:14, Jakub Kicinski wrote:
> On Thu, 28 Nov 2024 16:43:40 -0800 David Wei wrote:
>>> Just curious, why is this check needed everywhere? Is there a case
>>> where the 2 page pools can be the same ? I thought either there is a
>>> page_pool for the header frags or none at all ?  
>>
>> Yes, frags are always allocated now from head_pool, which is by default
>> the same as page_pool.
>>
>> If bnxt_separate_head_pool() then they are different.
> 
> Let's factor it out? We have 3 copies.

Sounds good. Will refactor into a helper.