netdev - Re: [Patch net v2] rtnetlink: fix double call of rtnl_link_get_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: 
 <173322243001.10445.16406152761850784134.git-patchwork-notify@kernel.org>
Date: Tue, 03 Dec 2024 10:40:30 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Cong Wang <xiyou.wangcong@...il.com>
Cc: netdev@...r.kernel.org, cong.wang@...edance.com,
 syzbot+21ba4d5adff0b6a7cfc6@...kaller.appspotmail.com, kuniyu@...zon.com
Subject: Re: [Patch net v2] rtnetlink: fix double call of rtnl_link_get_net_ifla()

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Fri, 29 Nov 2024 13:25:19 -0800 you wrote:
> From: Cong Wang <cong.wang@...edance.com>
> 
> Currently rtnl_link_get_net_ifla() gets called twice when we create
> peer devices, once in rtnl_add_peer_net() and once in each ->newlink()
> implementation.
> 
> This looks safer, however, it leads to a classic Time-of-Check to
> Time-of-Use (TOCTOU) bug since IFLA_NET_NS_PID is very dynamic. And
> because of the lack of checking error pointer of the second call, it
> also leads to a kernel crash as reported by syzbot.
> 
> [...]

Here is the summary with links:
  - [net,v2] rtnetlink: fix double call of rtnl_link_get_net_ifla()
    https://git.kernel.org/netdev/net/c/48327566769a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html