netdev - Re: [PATCH] ipv4: remove useless arg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85376cf2-0c95-4a08-bcbb-33c30c2f2c51@redhat.com>
Date: Tue, 3 Dec 2024 11:51:43 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: tianyu2 <tianyu2@...nelsoft.com>, eric.dumazet@...il.com,
 Pablo Neira Ayuso <pablo@...filter.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] ipv4: remove useless arg

On 12/2/24 04:32, tianyu2 wrote:
> The "struct sock *sk" parameter in ip_rcv_finish_core is unused, which
> leads the compiler to optimize it out. As a result, the
> "struct sk_buff *skb" parameter is passed using x1. And this make kprobe
> hard to use.
> 
> Signed-off-by: tianyu2 <tianyu2@...nelsoft.com>

The patch code good, but the above does not look like a real name?!?

If so, please re-submit, using your real full name and including the
target tree (net-next in this case) in the subj prefix.

See:
https://elixir.bootlin.com/linux/v6.12.1/source/Documentation/process/submitting-patches.rst#L440
https://elixir.bootlin.com/linux/v6.12.1/source/Documentation/process/maintainer-netdev.rst#L12

@Pablo: after this change will be merged, I *think* that a possible
follow-up could drop the 'sk' arg from NF_HOOK_LIST and ip_rcv_finish() too.

Thanks!

Paolo