netdev - Re: [PATCH net-next v7 2/9] lib: packing: demote truncation error in pack() to a warning in _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241203124316.er7w64rdkc4nedno@skbuf>
Date: Tue, 3 Dec 2024 14:43:16 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Tony Nguyen <anthony.l.nguyen@...el.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Masahiro Yamada <masahiroy@...nel.org>,
	netdev <netdev@...r.kernel.org>,
	Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net-next v7 2/9] lib: packing: demote truncation error in
 pack() to a warning in __pack()

On Mon, Dec 02, 2024 at 04:26:25PM -0800, Jacob Keller wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> Most of the sanity checks in pack() and unpack() can be covered at
> compile time. There is only one exception, and that is truncation of the
> uval during a pack() operation.
> 
> We'd like the error-less __pack() to catch that condition as well. But
> at the same time, it is currently the responsibility of consumer drivers
> (currently just sja1105) to print anything at all when this error
> occurs, and then discard the return code.
> 
> We can just print a loud warning in the library code and continue with
> the truncated __pack() operation. In practice, having the warning is
> very important, see commit 24deec6b9e4a ("net: dsa: sja1105: disallow
> C45 transactions on the BASE-TX MDIO bus") where the bug was caught
> exactly by noticing this print.
> 
> Add the first print to the packing library, and at the same time remove
> the print for the same condition from the sja1105 driver, to avoid
> double printing.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---

Somehow this is missing your sign off.