netdev - Re: [PATCH net] Revert "udp: avoid calling sock_def

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLQQ0_Wdt=W6Rd1uQJdnPVb_tK9tbnpE4JOkZmPUXEcOg@mail.gmail.com>
Date: Tue, 3 Dec 2024 13:58:58 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Fernando Fernandez Mancera <ffmancera@...eup.net>
Cc: netdev@...r.kernel.org, pabeni@...hat.com
Subject: Re: [PATCH net] Revert "udp: avoid calling sock_def_readable() if possible"

On Mon, Dec 2, 2024 at 4:56 PM Fernando Fernandez Mancera
<ffmancera@...eup.net> wrote:
>
> This reverts commit 612b1c0dec5bc7367f90fc508448b8d0d7c05414. On a
> scenario with multiple threads blocking on a recvfrom(), we need to call
> sock_def_readable() on every __udp_enqueue_schedule_skb() otherwise the
> threads won't be woken up as __skb_wait_for_more_packets() is using
> prepare_to_wait_exclusive().
>
> Link: https://bugzilla.redhat.com/2308477
> Fixes: 612b1c0dec5b ("udp: avoid calling sock_def_readable() if possible")
> Signed-off-by: Fernando Fernandez Mancera <ffmancera@...eup.net>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>