netdev - Re: [PATCH net] splice: do not checksum AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <537172.1733243422@warthog.procyon.org.uk>
Date: Tue, 03 Dec 2024 16:30:22 +0000
From: David Howells <dhowells@...hat.com>
To: Frederik Deweerdt <deweerdt.lkml@...il.com>
Cc: dhowells@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] splice: do not checksum AF_UNIX sockets

Frederik Deweerdt <deweerdt.lkml@...il.com> wrote:

> -			if (skb->ip_summed == CHECKSUM_NONE)
> +			if (skb->ip_summed == CHECKSUM_NONE && skb->sk->sk_family != AF_UNIX)
>  				skb_splice_csum_page(skb, page, off, part);

Should AF_UNIX set some other CHECKSUM_* constant indicating that the checksum
is unnecessary?

David