netdev - Re: [PATCH net] splice: do not checksum AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z098yHlrNYJsdzhM@pop-os.localdomain>
Date: Tue, 3 Dec 2024 13:48:56 -0800
From: Cong Wang <xiyou.wangcong@...il.com>
To: David Howells <dhowells@...hat.com>
Cc: Frederik Deweerdt <deweerdt.lkml@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net] splice: do not checksum AF_UNIX sockets

On Tue, Dec 03, 2024 at 04:30:22PM +0000, David Howells wrote:
> Frederik Deweerdt <deweerdt.lkml@...il.com> wrote:
> 
> > -			if (skb->ip_summed == CHECKSUM_NONE)
> > +			if (skb->ip_summed == CHECKSUM_NONE && skb->sk->sk_family != AF_UNIX)
> >  				skb_splice_csum_page(skb, page, off, part);
> 
> Should AF_UNIX set some other CHECKSUM_* constant indicating that the checksum
> is unnecessary?
> 

It already means unnecessary on TX path:

 * - %CHECKSUM_NONE
 *
 *   The skb was already checksummed by the protocol, or a checksum is not
 *   required.

Thanks.