netdev - Re: [PATCHv4] cxl: avoid driver data for obtaining cxl_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27ba1109-95d8-6091-5fce-bd00c68f2da1@amd.com>
Date: Tue, 3 Dec 2024 17:24:26 +0000
From: Alejandro Lucero Palau <alucerop@....com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: linux-cxl@...r.kernel.org, netdev@...r.kernel.org,
 dan.j.williams@...el.com, nifan.cxl@...il.com
Subject: Re: [PATCHv4] cxl: avoid driver data for obtaining cxl_dev_state
 reference


On 12/3/24 17:14, Jonathan Cameron wrote:
> On Tue, 3 Dec 2024 16:21:12 +0000
> <alucerop@....com> wrote:
>
>> From: Alejandro Lucero <alucerop@....com>
>>
>> CXL Type3 pci driver uses struct device driver_data for keeping
>> cxl_dev_state reference. Type1/2 drivers are not only about CXL so this
>> field should not be used when code requires cxl_dev_state to work with
>> and such a code used for Type2 support.
>>
>> Change cxl_dvsec_rr_decode for passing cxl_dev_state as a parameter.
>>
>> Seize the change for removing the unused cxl_port param.
>>
>> Signed-off-by: Alejandro Lucero <alucerop@....com>
> I wondered if the other places this assumption is made about drvdata
> would cause you trouble, but they seem ok for now at least as
> error handling code you probably won't use.


I think once the Type2 support is hopefully merged soon, it will be in 
the heads of all of us for avoiding this kind of uses. For the sake of 
that support, this patch is enough, but I bet we will find similar 
issues soon.


> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>


Thanks!