netdev - Re: [PATCH net-next 37/37] rxrpc: Implement RACK/TLP to deal with transmission stalls [RFC8985]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <726993.1733255693@warthog.procyon.org.uk>
Date: Tue, 03 Dec 2024 19:54:53 +0000
From: David Howells <dhowells@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: dhowells@...hat.com, netdev@...r.kernel.org,
    Marc Dionne <marc.dionne@...istor.com>,
    Yunsheng Lin <linyunsheng@...wei.com>,
    "David S. Miller" <davem@...emloft.net>,
    Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
    linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 37/37] rxrpc: Implement RACK/TLP to deal with transmission stalls [RFC8985]

Jakub Kicinski <kuba@...nel.org> wrote:

> On Mon,  2 Dec 2024 14:30:55 +0000 David Howells wrote:
> > +static inline ktime_t us_to_ktime(u64 us)
> > +{
> > +	return us * NSEC_PER_USEC;
> > +}
> 
> Is there a reason this doesn't exist in include/linux/ktime.h ?
> Given ns_to_ktime and ms_to_ktime already exist there adding a local
> but very similarly named helper in a local file appears questionable.

Yeah - I'll move it there.  It's just that winding backwards and forwards
through the patchset sucks if one of the patches modifies a major header.

David