netdev - Re: [PATCH net v3 0/3] bnxt_en: support header page pool in queue API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLin4bOBFbNRjYT9oL8N0z7SS=Nmrp6Bd+v_jeyP-4=eu1Q@mail.gmail.com>
Date: Wed, 4 Dec 2024 14:43:17 -0800
From: Michael Chan <michael.chan@...adcom.com>
To: David Wei <dw@...idwei.uk>
Cc: netdev@...r.kernel.org, Andy Gospodarek <andrew.gospodarek@...adcom.com>, 
	Somnath Kotur <somnath.kotur@...adcom.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net v3 0/3] bnxt_en: support header page pool in queue API

On Tue, Dec 3, 2024 at 8:10 PM David Wei <dw@...idwei.uk> wrote:
>
> Commit 7ed816be35ab ("eth: bnxt: use page pool for head frags") added a
> separate page pool for header frags. Now, frags are allocated from this
> header page pool e.g. rxr->tpa_info.data.
>
> The queue API did not properly handle rxr->tpa_info and so using the
> queue API to i.e. reset any queues will result in pages being returned
> to the incorrect page pool, causing inflight != 0 warnings.
>
> Fix this bug by properly allocating/freeing tpa_info and copying/freeing
> head_pool in the queue API implementation.
>
> The 1st patch is a prep patch that refactors helpers out to be used by
> the implementation patch later.
>
> The 2nd patch is a drive-by refactor. Happy to take it out and re-send
> to net-next if there are any objections.
>
> The 3rd patch is the implementation patch that will properly alloc/free
> rxr->tpa_info.

Thanks.
For the series,
Reviewed-by: Michael Chan <michael.chan@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)