netdev - Re: [PATCH iproute2-next, v3 2/2] iproute2: add 'ip monitor mcaddr' support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <617a5875-30ff-418e-998a-bef3c55924c1@6wind.com>
Date: Thu, 5 Dec 2024 09:26:02 +0100
From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
To: Yuyang Huang <yuyanghuang@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 David Ahern <dsahern@...nel.org>, roopa@...ulusnetworks.com,
 jiri@...nulli.us, stephen@...workplumber.org, jimictw@...gle.com,
 prohr@...gle.com, liuhangbin@...il.com, andrew@...n.ch,
 netdev@...r.kernel.org, Maciej Żenczykowski
 <maze@...gle.com>, Lorenzo Colitti <lorenzo@...gle.com>
Subject: Re: [PATCH iproute2-next, v3 2/2] iproute2: add 'ip monitor mcaddr'
 support

Le 04/12/2024 à 15:48, Yuyang Huang a écrit :
> Thanks for the review feedback.
> 
>> Note that 'ip maddr' (see 'man ip-maddress') already exists. Using 'mcaddr' for
>> 'ip monitor' is confusing.
> 
> Please allow me to confirm the suggestion, would it be less confusing
> if I use 'ip monitor maddr' here, or should I use a completely
> different name?
It's not the same API (netlink vs /proc) but the same objects at the end. It
seems better to me to have the same name. It enables updating the netlink API
later to get the same info as the one get in /proc.

Regards,
Nicolas