netdev - Re: [PATCH iproute2-next, v3 2/2] iproute2: add 'ip monitor mcaddr' support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADXeF1E1Ms4=sbUVZWEJ0S4KyY5cyP7hdk2eFnfT=_t+UG=euw@mail.gmail.com>
Date: Thu, 5 Dec 2024 19:45:34 +0900
From: Yuyang Huang <yuyanghuang@...gle.com>
To: nicolas.dichtel@...nd.com
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	David Ahern <dsahern@...nel.org>, roopa@...ulusnetworks.com, jiri@...nulli.us, 
	stephen@...workplumber.org, jimictw@...gle.com, prohr@...gle.com, 
	liuhangbin@...il.com, andrew@...n.ch, netdev@...r.kernel.org, 
	Maciej Żenczykowski <maze@...gle.com>, 
	Lorenzo Colitti <lorenzo@...gle.com>
Subject: Re: [PATCH iproute2-next, v3 2/2] iproute2: add 'ip monitor mcaddr' support

>It's not the same API (netlink vs /proc) but the same objects at the end. It
>seems better to me to have the same name. It enables updating the netlink API
>later to get the same info as the one get in /proc.

Thanks for the confirmation. I will use 'ip monitor maddr' in the next
patch version.

Thanks,
Yuyang

On Thu, Dec 5, 2024 at 5:26 PM Nicolas Dichtel
<nicolas.dichtel@...nd.com> wrote:
>
> Le 04/12/2024 à 15:48, Yuyang Huang a écrit :
> > Thanks for the review feedback.
> >
> >> Note that 'ip maddr' (see 'man ip-maddress') already exists. Using 'mcaddr' for
> >> 'ip monitor' is confusing.
> >
> > Please allow me to confirm the suggestion, would it be less confusing
> > if I use 'ip monitor maddr' here, or should I use a completely
> > different name?
> It's not the same API (netlink vs /proc) but the same objects at the end. It
> seems better to me to have the same name. It enables updating the netlink API
> later to get the same info as the one get in /proc.
>
>
> Regards,
> Nicolas