netdev - Re: [PATCH 14/16] net-next/yunsilicon: add ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1b54362-7156-4515-af54-e71aabd6c198@lunn.ch>
Date: Mon, 9 Dec 2024 14:53:28 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Tian Xin <tianx@...silicon.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, weihg@...silicon.com
Subject: Re: [PATCH 14/16] net-next/yunsilicon: add ndo_get_stats64

> +	adapter->stats = kvzalloc(sizeof(*adapter->stats), GFP_KERNEL);
> +	if (unlikely(!adapter->stats))
> +		goto err_detach;
> +

Please only use unlikely() in the hot path, handling packets.

Does it really matter if you save a couple of cycles during probe?

     Andrew