netdev - Re: [PATCH 14/16] net-next/yunsilicon: add ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <e9959d98-f46d-4562-9c8e-ac48859e8e45@yunsilicon.com>
Date: Wed, 18 Dec 2024 19:19:32 +0800
From: "tianx" <tianx@...silicon.com>
To: "Andrew Lunn" <andrew@...n.ch>
Cc: <netdev@...r.kernel.org>, <davem@...emloft.net>, <weihg@...silicon.com>
Subject: Re: [PATCH 14/16] net-next/yunsilicon: add ndo_get_stats64

Agreed, probe code doesn't need that level of attention. This have been 
modified in v1 code. Thanks for the reminder!


On 2024/12/9 21:53, Andrew Lunn wrote:
>> +	adapter->stats = kvzalloc(sizeof(*adapter->stats), GFP_KERNEL);
>> +	if (unlikely(!adapter->stats))
>> +		goto err_detach;
>> +
> Please only use unlikely() in the hot path, handling packets.
>
> Does it really matter if you save a couple of cycles during probe?
>
>       Andrew