netdev - Re: [PATCH 08/16] net-next/yunsilicon: Add ethernet interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <777765c7-c2b0-4347-9795-3b6f0c53dca6@yunsilicon.com>
Date: Wed, 18 Dec 2024 19:21:43 +0800
From: "tianx" <tianx@...silicon.com>
To: "Andrew Lunn" <andrew@...n.ch>
Cc: <netdev@...r.kernel.org>, <davem@...emloft.net>, <weihg@...silicon.com>
Subject: Re: [PATCH 08/16] net-next/yunsilicon: Add ethernet interface

OK, the unecessary log have been removed in v1 patch.

On 2024/12/9 21:41, Andrew Lunn wrote:
>> +static void xsc_remove_eth_driver(void)
>> +{
>> +	pr_info("remove ethernet driver\n");
>> +	xsc_unregister_interface(&xsc_interface);
>> +}
>> +
>> +static int xsc_net_reboot_event_handler(struct notifier_block *nb, unsigned long action, void *data)
>> +{
>> +	pr_info("xsc net driver recv %lu event\n", action);
>> +	xsc_remove_eth_driver();
>> +
>> +	return NOTIFY_OK;
>> +}
>> +
>> +struct notifier_block xsc_net_nb = {
>> +	.notifier_call = xsc_net_reboot_event_handler,
>> +	.next = NULL,
>> +	.priority = 1,
>> +};
>> +
>> +static __init int xsc_net_driver_init(void)
>> +{
>> +	int ret;
>> +
>> +	pr_info("add ethernet driver\n");
> Please don't spam the kernel log with all the pr_info() calls.
>
> 	Andrew