netdev - Re: [PATCH v1 net-next 07/15] af_unix: Call unix_autobind() only when msg_namelen is specified in unix_dgram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ddb27716-f1cc-4b65-9cba-b8f502f747ce@redhat.com>
Date: Tue, 10 Dec 2024 12:11:17 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>
Cc: Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 07/15] af_unix: Call unix_autobind() only when
 msg_namelen is specified in unix_dgram_sendmsg().

On 12/6/24 06:25, Kuniyuki Iwashima wrote:
> If unix_peer_get() returns non-NULL in unix_dgram_sendmsg(), the socket
> have been already bound in unix_dgram_connect() or unix_bind().
> 
> Let's not call unix_autobind() in such a case in unix_dgram_sendmsg().

AFACS, socketpair() will create unbound sockets with peer != NULL. It
looks like it break the above assumption?!?

Thanks,

Paolo