netdev - Re: [PATCH v1 net-next 07/15] af_unix: Call unix_autobind() only when msg_namelen is specified in unix_dgram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241210113314.98142-1-kuniyu@amazon.com>
Date: Tue, 10 Dec 2024 20:33:14 +0900
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <pabeni@...hat.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<kuni1840@...il.com>, <kuniyu@...zon.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v1 net-next 07/15] af_unix: Call unix_autobind() only when msg_namelen is specified in unix_dgram_sendmsg().

From: Paolo Abeni <pabeni@...hat.com>
Date: Tue, 10 Dec 2024 12:11:17 +0100
> On 12/6/24 06:25, Kuniyuki Iwashima wrote:
> > If unix_peer_get() returns non-NULL in unix_dgram_sendmsg(), the socket
> > have been already bound in unix_dgram_connect() or unix_bind().
> > 
> > Let's not call unix_autobind() in such a case in unix_dgram_sendmsg().
> 
> AFACS, socketpair() will create unbound sockets with peer != NULL. It
> looks like it break the above assumption?!?

Ah, I forgot about the case, thanks for catching!
I'll drop the patch in v2.