| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20241210120443.1813-1-jesse.vangavere@scioteq.com>
Date: Tue, 10 Dec 2024 13:04:43 +0100
From: Jesse Van Gavere <jesseevg@...il.com>
To: devicetree@...r.kernel.org
Cc: netdev@...r.kernel.org,
Marek Vasut <marex@...x.de>,
Conor Dooley <conor+dt@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Rob Herring <robh@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Jakub Kicinski <kuba@...nel.org>,
Eric Dumazet <edumazet@...gle.com>,
"David S . Miller" <davem@...emloft.net>,
Vladimir Oltean <olteanv@...il.com>,
Andrew Lunn <andrew@...n.ch>,
UNGLinuxDriver@...rochip.com,
Woojung Huh <woojung.huh@...rochip.com>,
Jesse Van Gavere <jesse.vangavere@...oteq.com>
Subject: [PATCH net-next] dt-bindings: net: dsa: microchip,ksz: Improve example to a working one
Currently the example will not work when implemented as-is as there are
some properties and nodes missing.
- Define two eth ports, one for each switch for clarity.
- Add mandatory dsa,member properties as it's a dual switch setup example.
- Add the mdio node for each switch and define the PHYs under it.
- Add a phy-mode and phy-handle to each port otherwise they won't come up.
- Add a mac-address property, without this the port does not come up, in
the example all 0 is used so the port replicates MAC from the CPU port
Signed-off-by: Jesse Van Gavere <jesse.vangavere@...oteq.com>
---
.../bindings/net/dsa/microchip,ksz.yaml | 89 +++++++++++++++++--
1 file changed, 83 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
index 62ca63e8a26f..a08ec0fd01fa 100644
--- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
@@ -145,13 +145,19 @@ examples:
- |
#include <dt-bindings/gpio/gpio.h>
- // Ethernet switch connected via SPI to the host, CPU port wired to eth0:
+ // Ethernet switches connected via SPI to the host, CPU ports wired to eth0 and eth1:
eth0 {
fixed-link {
speed = <1000>;
full-duplex;
};
};
+ eth1 {
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
spi {
#address-cells = <1>;
@@ -167,28 +173,46 @@ examples:
spi-max-frequency = <44000000>;
+ dsa,member = <0 0>;
+
ethernet-ports {
#address-cells = <1>;
#size-cells = <0>;
port@0 {
reg = <0>;
label = "lan1";
+ phy-mode = "internal";
+ phy-handle = <&switch0_phy0>;
+ // The MAC is duplicated from the CPU port when all 0
+ mac-address = [00 00 00 00 00 00];
};
port@1 {
reg = <1>;
label = "lan2";
+ phy-mode = "internal";
+ phy-handle = <&switch0_phy1>;
+ mac-address = [00 00 00 00 00 00];
};
port@2 {
reg = <2>;
label = "lan3";
+ phy-mode = "internal";
+ phy-handle = <&switch0_phy2>;
+ mac-address = [00 00 00 00 00 00];
};
port@3 {
reg = <3>;
label = "lan4";
+ phy-mode = "internal";
+ phy-handle = <&switch0_phy3>;
+ mac-address = [00 00 00 00 00 00];
};
port@4 {
reg = <4>;
label = "lan5";
+ phy-mode = "internal";
+ phy-handle = <&switch0_phy4>;
+ mac-address = [00 00 00 00 00 00];
};
port@5 {
reg = <5>;
@@ -201,6 +225,27 @@ examples:
};
};
};
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ switch0_phy0: ethernet-phy@0 {
+ reg = <0>;
+ };
+ switch0_phy1: ethernet-phy@1 {
+ reg = <1>;
+ };
+ switch0_phy2: ethernet-phy@2 {
+ reg = <2>;
+ };
+ switch0_phy3: ethernet-phy@3 {
+ reg = <3>;
+ };
+ switch0_phy4: ethernet-phy@4 {
+ reg = <4>;
+ };
+ };
};
ksz8565: switch@1 {
@@ -209,28 +254,42 @@ examples:
spi-max-frequency = <44000000>;
+ dsa,member = <1 0>;
+
ethernet-ports {
#address-cells = <1>;
#size-cells = <0>;
port@0 {
reg = <0>;
- label = "lan1";
+ label = "lan6";
+ phy-mode = "internal";
+ phy-handle = <&switch1_phy0>;
+ mac-address = [00 00 00 00 00 00];
};
port@1 {
reg = <1>;
- label = "lan2";
+ label = "lan7";
+ phy-mode = "internal";
+ phy-handle = <&switch1_phy1>;
+ mac-address = [00 00 00 00 00 00];
};
port@2 {
reg = <2>;
- label = "lan3";
+ label = "lan8";
+ phy-mode = "internal";
+ phy-handle = <&switch1_phy2>;
+ mac-address = [00 00 00 00 00 00];
};
port@3 {
reg = <3>;
- label = "lan4";
+ label = "lan9";
+ phy-mode = "internal";
+ phy-handle = <&switch1_phy3>;
+ mac-address = [00 00 00 00 00 00];
};
port@6 {
reg = <6>;
- ethernet = <ð0>;
+ ethernet = <ð1>;
phy-mode = "rgmii";
fixed-link {
@@ -239,6 +298,24 @@ examples:
};
};
};
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ switch1_phy0: ethernet-phy@0 {
+ reg = <0>;
+ };
+ switch1_phy1: ethernet-phy@1 {
+ reg = <1>;
+ };
+ switch1_phy2: ethernet-phy@2 {
+ reg = <2>;
+ };
+ switch1_phy3: ethernet-phy@3 {
+ reg = <3>;
+ };
+ };
};
};
...
--
2.34.1
Powered by blists - more mailing lists