netdev - Re: [PATCH net-next] dt-bindings: net: dsa: microchip,ksz: Improve example to a working one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dfb09395-78ce-477f-bbbc-747b0a234d4f@lunn.ch>
Date: Tue, 10 Dec 2024 14:35:26 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Jesse Van Gavere <jesseevg@...il.com>
Cc: devicetree@...r.kernel.org, netdev@...r.kernel.org,
	Marek Vasut <marex@...x.de>, Conor Dooley <conor+dt@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Rob Herring <robh@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	"David S . Miller" <davem@...emloft.net>,
	Vladimir Oltean <olteanv@...il.com>, UNGLinuxDriver@...rochip.com,
	Woojung Huh <woojung.huh@...rochip.com>,
	Jesse Van Gavere <jesse.vangavere@...oteq.com>
Subject: Re: [PATCH net-next] dt-bindings: net: dsa: microchip,ksz: Improve
 example to a working one

On Tue, Dec 10, 2024 at 01:04:43PM +0100, Jesse Van Gavere wrote:
> Currently the example will not work when implemented as-is as there are
> some properties and nodes missing.
> - Define two eth ports, one for each switch for clarity.
> - Add mandatory dsa,member properties as it's a dual switch setup example.
> - Add the mdio node for each switch and define the PHYs under it.
> - Add a phy-mode and phy-handle to each port otherwise they won't come up.
> - Add a mac-address property, without this the port does not come up, in
> the example all 0 is used so the port replicates MAC from the CPU port

To some extent, the example is for the properties defined in the
binding. For properties defined in other bindings, you should look at
the examples in other bindings, and then glue it all together in a
real .dts file.

I don't know if Rob will accept this patch.

	Andrew