netdev - Re: [PATCH net-next] dt-bindings: net: dsa: microchip,ksz: Improve example to a working one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMdwsN_Kgb23Rw0q041fFr9T70twx2vAX2J+MvJz+585ZyyanQ@mail.gmail.com>
Date: Tue, 10 Dec 2024 23:01:02 +0100
From: Jesse Van Gavere <jesseevg@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: devicetree@...r.kernel.org, netdev@...r.kernel.org, 
	Marek Vasut <marex@...x.de>, Conor Dooley <conor+dt@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, 
	"David S . Miller" <davem@...emloft.net>, Vladimir Oltean <olteanv@...il.com>, UNGLinuxDriver@...rochip.com, 
	Woojung Huh <woojung.huh@...rochip.com>, Jesse Van Gavere <jesse.vangavere@...oteq.com>
Subject: Re: [PATCH net-next] dt-bindings: net: dsa: microchip,ksz: Improve
 example to a working one

Hi Andrew

Op di 10 dec 2024 om 17:18 schreef Andrew Lunn <andrew@...n.ch>:
>
> To some extent, the example is for the properties defined in the
> binding. For properties defined in other bindings, you should look at
> the examples in other bindings, and then glue it all together in a
> real .dts file.
>
> I don't know if Rob will accept this patch.
>
>         Andrew

To some extent I understand that perspective, but in this case for
example dsa-port itself has no example, I also struggled quite a bit
getting the example going (admittedly a bit due to my lack of
experience, figuring out the dt-schema tool really helped as well).
In most cases when I look at an example I see the full scope of what
it should be (or at least enough to get started from there), and this
one seemed a bit off in that regard as it showcases itself as an
example but is missing some critical details.
The microchip,lan yaml in contrast does define these properties and I
think it gives a much clearer picture of how to implement it in a
device tree than expecting people to figure out all the places they
need to look and how to glue that together.
I don't think it's straightforward for most people getting into device
trees to know how to glue that all together and knowing where to look
to begin with, in that sense I figured updating this example might
help others trying to get this up and running.

Best regards,
Jesse