netdev - Re: [PATCH net 4/4] ice: Add correct PHY lane assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04a216d1-6952-40f0-b7d0-f9d8b4f5a866@redhat.com>
Date: Tue, 10 Dec 2024 15:54:55 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
 kuba@...nel.org, edumazet@...gle.com, andrew+netdev@...n.ch,
 netdev@...r.kernel.org
Cc: Karol Kolacinski <karol.kolacinski@...el.com>, richardcochran@...il.com,
 przemyslaw.kitszel@...el.com, horms@...nel.org,
 Arkadiusz Kubalewski <Arkadiusz.kubalewski@...el.com>,
 Grzegorz Nitka <grzegorz.nitka@...el.com>,
 Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net 4/4] ice: Add correct PHY lane assignment

On 12/6/24 20:35, Tony Nguyen wrote:
> diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c
> index 496d86cbd13f..ab25ccd7e8ec 100644
> --- a/drivers/net/ethernet/intel/ice/ice_common.c
> +++ b/drivers/net/ethernet/intel/ice/ice_common.c
> @@ -4095,6 +4095,51 @@ ice_aq_set_port_option(struct ice_hw *hw, u8 lport, u8 lport_valid,
>  	return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL);
>  }
>  
> +/**
> + * ice_get_phy_lane_number - Get PHY lane number for current adapter
> + * @hw: pointer to the hw struct
> + *
> + * Return: PHY lane number on success, negative error code otherwise.
> + */
> +int ice_get_phy_lane_number(struct ice_hw *hw)
> +{
> +	struct ice_aqc_get_port_options_elem *options __free(kfree);

Please avoid the __free() construct:

https://elixir.bootlin.com/linux/v6.13-rc2/source/Documentation/process/maintainer-netdev.rst#L393

Thanks,

Paolo