netdev - Re: [PATCH net-next 2/5] ionic: Use VLAN_ETH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c021b7d-4e1d-4bf4-82b4-f6b88a5df53e@intel.com>
Date: Tue, 10 Dec 2024 14:45:27 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Shannon Nelson <shannon.nelson@....com>, <netdev@...r.kernel.org>,
	<davem@...emloft.net>, <kuba@...nel.org>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <andrew+netdev@...n.ch>
CC: <brett.creeley@....com>
Subject: Re: [PATCH net-next 2/5] ionic: Use VLAN_ETH_HLEN when possible



On 12/10/2024 10:30 AM, Shannon Nelson wrote:
> From: Brett Creeley <brett.creeley@....com>
> 
> Replace when ETH_HLEN and VLAN_HLEN are used together with
> VLAN_ETH_HLEN since it's the same value and uses 1 define
> instead of 2.
> 
> Signed-off-by: Brett Creeley <brett.creeley@....com>
> Signed-off-by: Shannon Nelson <shannon.nelson@....com>
> ---
>  drivers/net/ethernet/pensando/ionic/ionic_lif.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> index 40496587b2b3..052c767a2c75 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> @@ -3265,7 +3265,7 @@ int ionic_lif_alloc(struct ionic *ionic)
>  	lif->netdev->min_mtu = max_t(unsigned int, ETH_MIN_MTU,
>  				     le32_to_cpu(lif->identity->eth.min_frame_size));
>  	lif->netdev->max_mtu =
> -		le32_to_cpu(lif->identity->eth.max_frame_size) - ETH_HLEN - VLAN_HLEN;
> +		le32_to_cpu(lif->identity->eth.max_frame_size) - VLAN_ETH_HLEN;
>  
>  	lif->neqs = ionic->neqs_per_lif;
>  	lif->nxqs = ionic->ntxqs_per_lif;

Nice shorter line.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>