netdev - Re: [PATCH net-next 3/5] ionic: Translate IONIC_RC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f2df5cf-5e70-45ac-b1a1-a13af4ec5167@intel.com>
Date: Tue, 10 Dec 2024 14:45:54 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Shannon Nelson <shannon.nelson@....com>, <netdev@...r.kernel.org>,
	<davem@...emloft.net>, <kuba@...nel.org>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <andrew+netdev@...n.ch>
CC: <brett.creeley@....com>
Subject: Re: [PATCH net-next 3/5] ionic: Translate IONIC_RC_ENOSUPP to
 EOPNOTSUPP



On 12/10/2024 10:30 AM, Shannon Nelson wrote:
> From: Brett Creeley <brett.creeley@....com>
> 
> Instead of reporting -EINVAL when IONIC_RC_ENOSUPP is returned use
> the -EOPNOTSUPP value. This aligns better since the FW only returns
> IONIC_RC_ENOSUPP when operations aren't supported not when invalid
> values are used.
> 
> Signed-off-by: Brett Creeley <brett.creeley@....com>
> Signed-off-by: Shannon Nelson <shannon.nelson@....com>
> ---

Makes sense.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  drivers/net/ethernet/pensando/ionic/ionic_main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_main.c b/drivers/net/ethernet/pensando/ionic/ionic_main.c
> index 0f817c3f92d8..daf1e82cb76b 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_main.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_main.c
> @@ -81,8 +81,9 @@ static int ionic_error_to_errno(enum ionic_status_code code)
>  	case IONIC_RC_EQTYPE:
>  	case IONIC_RC_EQID:
>  	case IONIC_RC_EINVAL:
> -	case IONIC_RC_ENOSUPP:
>  		return -EINVAL;
> +	case IONIC_RC_ENOSUPP:
> +		return -EOPNOTSUPP;
>  	case IONIC_RC_EPERM:
>  		return -EPERM;
>  	case IONIC_RC_ENOENT: