netdev - Re: [PATCH net-next 03/10] net: phy: add configuration of rx clock stop mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da8a3b81-33aa-46a5-b068-cb80c7464cc8@lunn.ch>
Date: Wed, 11 Dec 2024 00:15:57 +0100
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Bryan Whitehead <bryan.whitehead@...rochip.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Marcin Wojtas <marcin.s.wojtas@...il.com>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next 03/10] net: phy: add configuration of rx clock
 stop mode

On Tue, Dec 10, 2024 at 09:51:54AM +0000, Russell King (Oracle) wrote:
> On Tue, Dec 10, 2024 at 04:11:09AM +0100, Andrew Lunn wrote:
> > > @@ -2073,6 +2073,7 @@ int phy_unregister_fixup_for_id(const char *bus_id);
> > >  int phy_unregister_fixup_for_uid(u32 phy_uid, u32 phy_uid_mask);
> > >  
> > >  int phy_eee_tx_clock_stop_capable(struct phy_device *phydev);
> > > +int phy_eee_rx_clock_stop(struct phy_device *phydev, bool clk_stop_enable);
> > 
> > Hi Russell
> > 
> > Do you have patches to MAC drivers using phylib, not phylink, using
> > these two new calls?
> > 
> > We see phylib users get EEE wrong. I'm worried phylib users are going
> > to try to use these new API methods and make an even bigger mess. If
> > we think these should only be used by phylink, maybe they should be
> > put into a header in drivers/net/phy to stop MAC drivers using them?
> 
> If we want to fix the current phylib-using drivers, then we do need
> at minimum phy_eee_rx_clock_stop() to do that - we have drivers that
> call phy_init_eee(..., true) which would need to call this.

phy_init_eee() needs to die, so we need this one. 

But we should consider the other one, do we want to make it private?

	Andrew