netdev - Re: [PATCH net-next 4/5] ionic: add speed defines for 200G and 400G

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b044a65f-ad68-4d30-9e98-876de8f55faf@amd.com>
Date: Tue, 10 Dec 2024 15:21:06 -0800
From: "Nelson, Shannon" <shannon.nelson@....com>
To: Jacob Keller <jacob.e.keller@...el.com>, netdev@...r.kernel.org,
 davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch
Cc: brett.creeley@....com
Subject: Re: [PATCH net-next 4/5] ionic: add speed defines for 200G and 400G

On 12/10/2024 2:53 PM, Jacob Keller wrote:
> On 12/10/2024 10:30 AM, Shannon Nelson wrote:
>> Add higher speed defines to the ionic_if.h API and decode them
>> in the ethtool get_link_ksettings callback.
>>
>> Signed-off-by: Shannon Nelson <shannon.nelson@....com>
>> ---
> 
> You might consider refactoring the ionic driver to use the
> ethtool_forced_speed_maps_init interface at some point. See 26c5334d344d
> ("ethtool: Add forced speed to supported link modes maps"), with
> 982b0192db45 ("ice: Refactor finding advertised link speed") and
> 1d4e4ecccb11 ("qede: populate supported link modes maps on module init")
> (though it looks like the latter hasn't moved to the ethtool function).
> 
> This saves a bunch of text size on the module.

Yeah, and it would get rid of the silly CamelCase code complaints as 
well.  We'll have to take look at this in a future opportunity.

Thanks for the Reviews,
sln