netdev - Re: [PATCH net-next 06/10] net: phylink: allow MAC driver to validate eee params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a72db39a-ca78-43bc-a15b-5f1ab39af661@lunn.ch>
Date: Tue, 10 Dec 2024 04:21:51 +0100
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Bryan Whitehead <bryan.whitehead@...rochip.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Marcin Wojtas <marcin.s.wojtas@...il.com>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next 06/10] net: phylink: allow MAC driver to
 validate eee params

> +/**
> + * mac_validate_tx_lpi() - validate the LPI parameters in EEE
> + * @config: a pointer to a &struct phylink_config.
> + * @e: EEE configuration to be validated.
> + *
> + * Validate the LPI configuration parameters in @e, returning an appropriate
> + * error. This will be called prior to any changes being made, and must not
> + * make any changes to existing configuration. Returns zero on success.

Maybe suggest -EOPNOTSUPP? We might then get more uniform error codes
from MAC drivers?

	Andrew