netdev - Re: [PATCH net-next, v5] netlink: add IGMP/MLD join/leave notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241210165024.07baa835@kernel.org>
Date: Tue, 10 Dec 2024 16:50:24 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Yuyang Huang <yuyanghuang@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, David Ahern <dsahern@...nel.org>,
 roopa@...ulusnetworks.com, jiri@...nulli.us, stephen@...workplumber.org,
 jimictw@...gle.com, prohr@...gle.com, liuhangbin@...il.com,
 nicolas.dichtel@...nd.com, andrew@...n.ch, netdev@...r.kernel.org, Maciej
 Żenczykowski <maze@...gle.com>, Lorenzo Colitti
 <lorenzo@...gle.com>, Patrick Ruddy <pruddy@...tta.att-mail.com>
Subject: Re: [PATCH net-next, v5] netlink: add IGMP/MLD join/leave
 notifications

On Tue, 10 Dec 2024 12:19:11 +0900 Yuyang Huang wrote:
> >u8 scope = RT_SCOPE_UNIVERSE;
> >struct nlmsghdr *nlh;
> >if (ipv6_addr_scope(&ifmca->mca_addr) & IFA_SITE)  
> scope = RT_SCOPE_SITE;
> 
> Is it acceptable, or should I update the old logic to always set
> ‘RT_SCOPE_UNIVERSE’?

TBH I'm not an expert on IPv6 address scopes, why do we want to ignore
it now? Some commit or RFC we can refer to?

Perhaps you could add a new member to inet6_fill_args to force the
scope to always be set to universe?