netdev - Re: [PATCH net-next v6 3/4] selftests: net: test SO_PRIORITY ancillary data with cmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6758e34d1b9c_3ed2bc294c0@willemb.c.googlers.com.notmuch>
Date: Tue, 10 Dec 2024 19:56:45 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Anna Emese Nyiri <annaemesenyiri@...il.com>, 
 netdev@...r.kernel.org
Cc: fejes@....elte.hu, 
 edumazet@...gle.com, 
 kuba@...nel.org, 
 pabeni@...hat.com, 
 willemb@...gle.com, 
 idosch@...sch.org, 
 Anna Emese Nyiri <annaemesenyiri@...il.com>
Subject: Re: [PATCH net-next v6 3/4] selftests: net: test SO_PRIORITY
 ancillary data with cmsg_sender

Anna Emese Nyiri wrote:
> Extend cmsg_sender.c with a new option '-Q' to send SO_PRIORITY
> ancillary data.
> 
> cmsg_so_priority.sh script added to validate SO_PRIORITY behavior 
> by creating VLAN device with egress QoS mapping and testing packet
> priorities using flower filters. Verify that packets with different
> priorities are correctly matched and counted by filters for multiple
> protocols and IP versions.
> 
> Suggested-by: Ido Schimmel <idosch@...sch.org>
> Signed-off-by: Anna Emese Nyiri <annaemesenyiri@...il.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>


> +            ip netns exec $NS ./cmsg_sender -$i -Q $priority -d "${DELAY}" \
> +	            -p $proto $TGT $PORT
> +
> +            pkts=$(tc -n $NS -j -s filter show dev dummy1 egress \
> +                | jq ".[] | select(.options.handle == ${handle}) | \
> +                .options.actions[0].stats.packets")
> +            if [[ $pkts == 1 ]]; then
> +                check_result 0
> +            else
> +                echo "prio $priority -Q: expected 1, got $pkts"
> +                check_result 1
> +            fi
> +
> +            ip netns exec $NS ./cmsg_sender -$i -P $priority -d "${DELAY}" \
> +	            -p $proto $TGT $PORT

nit: delay is not used here. Neither txtime nor ts is set (and only
one packet is sent). It's harmless. No need to respin just for this.