netdev - Re: [PATCH net-next 07/10] net: mvneta: convert to phylink EEE implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1wRwLSgTutZyitP@shell.armlinux.org.uk>
Date: Fri, 13 Dec 2024 10:51:44 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Simon Horman <horms@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Bryan Whitehead <bryan.whitehead@...rochip.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Marcin Wojtas <marcin.s.wojtas@...il.com>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next 07/10] net: mvneta: convert to phylink EEE
 implementation

On Fri, Dec 13, 2024 at 10:22:11AM +0000, Simon Horman wrote:
> > Hi Russell,
> > 
> > I think that the val and field arguments to u32_replace_bits() are
> > inverted here and this should be:
> > 
> > 	lpi0 = u32_replace_bits(lpi0, ts, MVNETA_LPI_CTRL_0_TS);
> > 
> > > +	mvreg_write(pp, MVNETA_LPI_CTRL_0, lpi0);
> > > +
> > > +	/* Configure tw and enable LPI generation */
> > > +	lpi1 = mvreg_read(pp, MVNETA_LPI_CTRL_1);
> > > +	lpi1 = u32_replace_bits(lpi1, MVNETA_LPI_CTRL_1_TW, tw);
> > 
> > Ditto.
> > 
> > > +	lpi1 |= MVNETA_LPI_CTRL_1_REQUEST_ENABLE;
> > > +	mvreg_write(pp, MVNETA_LPI_CTRL_1, lpi1);
> > >  }
> > >  
> > >  static const struct phylink_mac_ops mvneta_phylink_ops = {
> > 
> > Flagged by clang-19 and gcc-14 W=1 builds.
> > 
> > ...
> 
> Sorry for more noise, and perhaps this is obvious.
> But a similar problem seems to also exists in the following patch,
> [PATCH] net: mvpp2: add EEE implementation.

Thanks Simon, the 0-day bot flagged them and have already been fixed.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!