netdev - Re: [PATCH net 0/5] netdev: fix repeated netlink messages in queue dumps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1ysi1RHOr3S-40F@LQ3V64L9R2>
Date: Fri, 13 Dec 2024 13:52:11 -0800
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com
Subject: Re: [PATCH net 0/5] netdev: fix repeated netlink messages in queue
 dumps

On Fri, Dec 13, 2024 at 07:22:39AM -0800, Jakub Kicinski wrote:
> Fix dump continuation for queues and queue stats in the netdev family.
> Because we used post-increment when saving id of dumped queue next
> skb would re-dump the already dumped queue.
> 
> Jakub Kicinski (5):
>   netdev: fix repeated netlink messages in queue dump
>   netdev: fix repeated netlink messages in queue stats
>   selftests: net: support setting recv_size in YNL
>   selftests: net-drv: queues: sanity check netlink dumps
>   selftests: net-drv: stats: sanity check netlink dumps

Thanks for the work and improvements.

Patch 1 and 2 definitely seem to be "fixes" and are against net
which seems appropriate to me.

Patches 3, 4, and 5 seem like new features, though. Should those
three be a separate series against net-next, instead?

In the event that you do decide to separate out 3, 4, and 5 you can
feel free to carry along my Reviewed-bys.