netdev - Re: [PATCH v3 net-next 4/5] ipv6: tcp: give socket pointer to control skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2KHMLJ4oTUwgBSo@gauss3.secunet.de>
Date: Wed, 18 Dec 2024 09:26:24 +0100
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Eric Dumazet <edumazet@...gle.com>
CC: Shahar Shitrit <shshitrit@...dia.com>, "brianvv@...gle.com"
	<brianvv@...gle.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "kuniyu@...zon.com" <kuniyu@...zon.com>,
	"martin.lau@...nel.org" <martin.lau@...nel.org>, "ncardwell@...gle.com"
	<ncardwell@...gle.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, Tariq Toukan <tariqt@...dia.com>,
	Gal Pressman <gal@...dia.com>, Ziyad Atiyyeh <ziyadat@...dia.com>, "Dror
 Tennenbaum" <drort@...dia.com>
Subject: Re: [PATCH v3 net-next 4/5] ipv6: tcp: give socket pointer to
 control skbs

On Mon, Dec 16, 2024 at 04:21:32PM +0100, Eric Dumazet wrote:
> On Mon, Dec 16, 2024 at 2:29 PM Eric Dumazet <edumazet@...gle.com> wrote:
> >
> > On Mon, Dec 16, 2024 at 2:18 PM Shahar Shitrit <shshitrit@...dia.com> wrote:
> > >
> > > Hello,
> > >
> > >
> > >
> > > We observe memory leaks reported by kmemleak when using IPSec in transport mode with crypto offload.
> > >
> > > The leaks reproduce for TX offload, RX offload and both.
> > >
> > > The leaks as shown in stack trace can be seen below.
> > >
> > >
> > >
> > > The issue has been bisected to this commit 507a96737d99686ca1714c7ba1f60ac323178189.
> > >
> > >
> >
> > Nothing comes to mind. This might be an old bug in loopback paths.
> 
> Or some XFRM assumption.
> 
> Note that ip6_xmit() first parameter can be different than skb->sk
> 
> Apparently, xfrm does not check this possibility.

Can you provide a bit more context? I don't see the problem.

Thanks!