netdev - Re: xfrm in RT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2KImhGE2TfpgG4E@gauss3.secunet.de>
Date: Wed, 18 Dec 2024 09:32:26 +0100
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
CC: Sebastian Sewior <bigeasy@...utronix.de>, Network Development
	<netdev@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org>
Subject: Re: xfrm in RT

On Tue, Dec 17, 2024 at 04:07:16PM -0800, Alexei Starovoitov wrote:
> Hi,
> 
> Looks like xfrm isn't friendly to PREEMPT_RT.
> xfrm_input_state_lookup() is doing:
> 
> int cpu = get_cpu();
> ...
> spin_lock_bh(&net->xfrm.xfrm_state_lock);

We just need the cpu as a lookup key, no need to
hold on the cpu. So we just can do put_cpu()
directly after we fetched the value.

I'll fix that,

thanks!