netdev - Re: [PATCH net] netdev-genl: avoid empty messages in queue dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+oW5tu0JkOREsh0CEFwaWsWsfP-PpMTouQ7HZDDunFJg@mail.gmail.com>
Date: Wed, 18 Dec 2024 11:49:47 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com, 
	syzbot+0a884bc2d304ce4af70f@...kaller.appspotmail.com, jdamato@...tly.com, 
	almasrymina@...gle.com, sridhar.samudrala@...el.com, 
	amritha.nambiar@...el.com
Subject: Re: [PATCH net] netdev-genl: avoid empty messages in queue dump

On Wed, Dec 18, 2024 at 3:25 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Empty netlink responses from do() are not correct (as opposed to
> dump() where not dumping anything is perfectly fine).
> We should return an error if the target object does not exist,
> in this case if the netdev is down it has no queues.
>
> Fixes: 6b6171db7fc8 ("netdev-genl: Add netlink framework functions for queue")
> Reported-by: syzbot+0a884bc2d304ce4af70f@...kaller.appspotmail.com
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>