netdev - Re: [PATCH net] netdev-genl: avoid empty messages in queue dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2MMWeVefydph52d@LQ3V64L9R2>
Date: Wed, 18 Dec 2024 09:54:33 -0800
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com,
	syzbot+0a884bc2d304ce4af70f@...kaller.appspotmail.com,
	almasrymina@...gle.com, sridhar.samudrala@...el.com,
	amritha.nambiar@...el.com
Subject: Re: [PATCH net] netdev-genl: avoid empty messages in queue dump

On Tue, Dec 17, 2024 at 06:25:08PM -0800, Jakub Kicinski wrote:
> Empty netlink responses from do() are not correct (as opposed to
> dump() where not dumping anything is perfectly fine).
> We should return an error if the target object does not exist,
> in this case if the netdev is down it has no queues.
> 
> Fixes: 6b6171db7fc8 ("netdev-genl: Add netlink framework functions for queue")
> Reported-by: syzbot+0a884bc2d304ce4af70f@...kaller.appspotmail.com
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: jdamato@...tly.com
> CC: almasrymina@...gle.com
> CC: sridhar.samudrala@...el.com
> CC: amritha.nambiar@...el.com
> ---
>  net/core/netdev-genl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c
> index 9527dd46e4dc..b4becd4065d9 100644
> --- a/net/core/netdev-genl.c
> +++ b/net/core/netdev-genl.c
> @@ -430,10 +430,10 @@ static int
>  netdev_nl_queue_fill(struct sk_buff *rsp, struct net_device *netdev, u32 q_idx,
>  		     u32 q_type, const struct genl_info *info)
>  {
> -	int err = 0;
> +	int err;
>  
>  	if (!(netdev->flags & IFF_UP))
> -		return err;
> +		return -ENOENT;
>  
>  	err = netdev_nl_queue_validate(netdev, q_idx, q_type);
>  	if (err)

Reviewed-by: Joe Damato <jdamato@...tly.com>