netdev - Re: [PATCH net-next v3 0/7] vsock/test: Tests for memory leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cznhfgfnie3nves5bmxn2djchinlsp6jvdaxguhlbs7h5ndhe@vbhx5lvockmj>
Date: Wed, 18 Dec 2024 18:58:36 +0100
From: Stefano Garzarella <sgarzare@...hat.com>
To: Michal Luczaj <mhal@...x.co>
Cc: netdev@...r.kernel.org, Luigi Leonardi <leonardi@...hat.com>, 
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v3 0/7] vsock/test: Tests for memory leaks

On Wed, Dec 18, 2024 at 03:38:17PM +0100, Michal Luczaj wrote:
>On 12/18/24 15:32, Michal Luczaj wrote:
>> Series adds tests for recently fixed memory leaks[1]:
>>
>> commit d7b0ff5a8667 ("virtio/vsock: Fix accept_queue memory leak")
>> commit fbf7085b3ad1 ("vsock: Fix sk_error_queue memory leak")
>> commit 60cf6206a1f5 ("virtio/vsock: Improve MSG_ZEROCOPY error handling")
>>
>> Patch 1/6 is a non-functional preparatory cleanup.
>> Patch 2/6 is a test suite extension for picking specific tests.
>> Patch 3/6 explains the need of kmemleak scans.
>> Patches 4-5-6 add the tests.
>>
>> NOTE: Test in patch 6/6 ("vsock/test: Add test for MSG_ZEROCOPY completion
>> memory leak") may stop working even before this series is merged. See
>> changes proposed in [2]. The failslab variant would be unaffected. [...]
>
>Bah, I've added one more patch: "vsock/test: Adapt send_byte()/recv_byte()
>to handle MSG_ZEROCOPY" and broke the numbering above, sorry.

Not a problem at all ;-)

Thanks for this series again, LGTM!
I reviewed all of the patches and tested them.

Stefano