netdev - Re: [PATCH net-next 0/4] selftests/net: packetdrill: import multiple tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241218100013.0c698629@kernel.org>
Date: Wed, 18 Dec 2024 10:00:13 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Soham Chakradeo <sohamch.kernel@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, linux-kselftest@...r.kernel.org, Soham Chakradeo
 <sohamch@...gle.com>, Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next 0/4] selftests/net: packetdrill: import
 multiple tests

On Tue, 17 Dec 2024 18:51:57 +0000 Soham Chakradeo wrote:
> Import tests for the following features (folder names in brackets):
> ECN (ecn) : RFC 3168
> Close (close) : RFC 9293
> TCP_INFO (tcp_info) : RFC 9293
> Fast recovery (fast_recovery) : RFC 5681
> Timestamping (timestamping) : RFC 1323
> Nagle (nagle) : RFC 896
> Selective Acknowledgments (sack) : RFC 2018
> Recent Timestamp (ts_recent) : RFC 1323
> Send file (sendfile)
> Syscall bad arg (syscall_bad_arg)
> Validate (validate)
> Blocking (blocking)
> Splice (splice)
> End of record (eor)
> Limited transmit (limited_transmit)

Excellent, thanks for adding all these! I will merge the patches
momentarily but I do see a number of flakes on our VMs with debug
configs enabled:
https://netdev.bots.linux.dev/flakes.html?min-flip=0&tn-needle=packetdrill-dbg

In the 7 runs so far we got 2 flakes on:

 tcp-timestamping-client-only-last-byte-pkt
 tcp-fast-recovery-prr-ss-ack-below-snd-una-cubic-pkt
 tcp-timestamping-server-pkt

1 flake on:

 tcp-timestamping-partial-pkt
 tcp-eor-no-coalesce-retrans-pkt

LMK if you can't find the outputs, they should be there within a couple
of clicks.

I'll set these cases to be ignored for now, but would be great if we
could find the way for them to be less time sensitive, perhaps?