netdev - Re: [PATCH net-next] eth: fbnic: fix csr boundary for RPM RAM section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a375625-5016-4f4a-a5fa-5a73dc536651@lunn.ch>
Date: Thu, 19 Dec 2024 09:25:41 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Mohsin Bashir <mohsin.bashr@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kuba@...nel.org,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, kernel-team@...a.com
Subject: Re: [PATCH net-next] eth: fbnic: fix csr boundary for RPM RAM section

On Wed, Dec 18, 2024 at 03:25:58PM -0800, Mohsin Bashir wrote:
> The CSR dump support leverages the FBNIC_BOUNDS macro, which pads the end
> condition for each section by adding an offset of 1. However, the RPC RAM
> section, which is dumped differently from other sections, does not rely
> on this macro and instead directly uses end boundary address. Hence,
> subtracting 1 from the end address results in skipping a register.

Maybe it would be better to actually use FBNIC_BOUNDS macro, to make
it the same as all the others, and so avoid errors like this because
it is special?

	Andrew