netdev - Re: [PATCH net-next] eth: fbnic: fix csr boundary for RPM RAM section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2PLtrFNzYsRSstx@mev-dev.igk.intel.com>
Date: Thu, 19 Dec 2024 08:31:02 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Mohsin Bashir <mohsin.bashr@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kuba@...nel.org,
	andrew@...n.ch, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, pabeni@...hat.com, kernel-team@...a.com
Subject: Re: [PATCH net-next] eth: fbnic: fix csr boundary for RPM RAM section

On Wed, Dec 18, 2024 at 03:25:58PM -0800, Mohsin Bashir wrote:
> The CSR dump support leverages the FBNIC_BOUNDS macro, which pads the end
> condition for each section by adding an offset of 1. However, the RPC RAM
> section, which is dumped differently from other sections, does not rely
> on this macro and instead directly uses end boundary address. Hence,
> subtracting 1 from the end address results in skipping a register.
> 
> Fixes 3d12862b216d (âeth: fbnic: Add support to dump registersâ)
> Signed-off-by: Mohsin Bashir <mohsin.bashr@...il.com>
> ---
>  drivers/net/ethernet/meta/fbnic/fbnic_csr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_csr.c b/drivers/net/ethernet/meta/fbnic/fbnic_csr.c
> index 2118901b25e9..aeb9f333f4c7 100644
> --- a/drivers/net/ethernet/meta/fbnic/fbnic_csr.c
> +++ b/drivers/net/ethernet/meta/fbnic/fbnic_csr.c
> @@ -64,7 +64,7 @@ static void fbnic_csr_get_regs_rpc_ram(struct fbnic_dev *fbd, u32 **data_p)
>  	u32 i, j;
>  
>  	*(data++) = start;
> -	*(data++) = end - 1;
> +	*(data++) = end;
>  
>  	/* FBNIC_RPC_TCAM_ACT */
>  	for (i = 0; i < FBNIC_RPC_TCAM_ACT_NUM_ENTRIES; i++) {
> -- 

Thanks,
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

> 2.43.5