netdev - Re: [PATCH] percpu: Remove intermediate variable in PERCPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20241219145110.a4815019ca69d6d5c36f1fdf@linux-foundation.org>
Date: Thu, 19 Dec 2024 14:51:10 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Uros Bizjak <ubizjak@...il.com>
Cc: Gal Pressman <gal@...dia.com>, Dennis Zhou <dennis@...nel.org>, Tejun
 Heo <tj@...nel.org>, Christoph Lameter <cl@...ux.com>, Nathan Chancellor
 <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Bill
 Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
 netdev@...r.kernel.org
Subject: Re: [PATCH] percpu: Remove intermediate variable in PERCPU_PTR()

On Thu, 19 Dec 2024 18:03:47 +0100 Uros Bizjak <ubizjak@...il.com> wrote:

> > Actually, you can simplify the above a bit by writing it as:
> >
> > #define PERCPU_PTR(__p)                            \
> >     ((typeof(*(__p)) __force __kernel *)(__force unsigned long)(__p)) \
> 
> Andrew, please find attached a substitute patch "[PATCH 4/6] percpu:
> Use TYPEOF_UNQUAL() in *_cpu_ptr() accessors" for your MM tree
> relative to the above hotfix. The whole patch series (+ hotfix) has
> been re-tested against the current mainline defconfig (+ KASAN),
> compiled once with gcc-11.4.1 and once with gcc-14.2.1.

Updated, thanks.

>  #define PERCPU_PTR(__p)							\
> -	((typeof(*(__p)) __force __kernel *)(__force unsigned long)(__p)) \
> +	((TYPEOF_UNQUAL(*(__p)) __force __kernel *)(__force unsigned long)(__p)) \
>

I removed that final " \".