netdev - Re: [PATCH net-next 3/9] ipv6: fib_rules: Add flow label support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241218190509.5aba9223@kernel.org>
Date: Wed, 18 Dec 2024 19:05:09 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Ido Schimmel <idosch@...dia.com>
Cc: <netdev@...r.kernel.org>, <davem@...emloft.net>, <pabeni@...hat.com>,
 <edumazet@...gle.com>, <dsahern@...nel.org>, <donald.hunter@...il.com>,
 <horms@...nel.org>, <gnault@...hat.com>, <rostedt@...dmis.org>,
 <mhiramat@...nel.org>, <mathieu.desnoyers@...icios.com>, <petrm@...dia.com>
Subject: Re: [PATCH net-next 3/9] ipv6: fib_rules: Add flow label support

On Mon, 16 Dec 2024 19:11:55 +0200 Ido Schimmel wrote:
> +	if (flowlabel_mask & ~IPV6_FLOWLABEL_MASK) {
> +		NL_SET_ERR_MSG_ATTR(extack, tb[FRA_FLOWLABEL_MASK],
> +				    "Invalid flow label mask");
> +		return -EINVAL;
> +	}

Have you considered NLA_POLICY_MASK() ?
Technically it does support be32, but we'd need to bswap ~IPV6_FLOWLABEL_MASK
and you need the helper anyway... so up to you.

> +	if (flowlabel & ~flowlabel_mask) {
> +		NL_SET_ERR_MSG(extack, "Flow label and mask do not match");
> +		return -EINVAL;
> +	}