netdev - Re: [PATCH net-next v2] net: ethtool: Fix suspicious rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iK0VdrCV7Hk=vjT4t3v=OJZXnKaOiMuTN_=ZDzDEuCzvQ@mail.gmail.com>
Date: Fri, 20 Dec 2024 17:33:41 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	syzbot+a344326c05c98ba19682@...kaller.appspotmail.com, 
	thomas.petazzoni@...tlin.com, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next v2] net: ethtool: Fix suspicious rcu_dereference usage

On Fri, Dec 20, 2024 at 9:37 AM Kory Maincent <kory.maincent@...tlin.com> wrote:
>
> The __ethtool_get_ts_info function can be called with or without the
> rtnl lock held. When the rtnl lock is not held, using rtnl_dereference()
> triggers a warning due to the lack of lock context.
>
> Add an rcu_read_lock() to ensure the lock is acquired and to maintain
> synchronization.
>
> Reported-by: syzbot+a344326c05c98ba19682@...kaller.appspotmail.com
> Closes: https://lore.kernel.org/netdev/676147f8.050a0220.37aaf.0154.GAE@google.com/
> Fixes: b9e3f7dc9ed9 ("net: ethtool: tsinfo: Enhance tsinfo to support several hwtstamp by net topology")
> Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>